Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 31 Aug 2020 09:55:37 +0300 (MSK)
From: Alexander Monakov <amonakov@...ras.ru>
To: musl@...ts.openwall.com
cc: Theodore Dubois <tblodt@...oud.com>
Subject: Re: i386 __set_thread_area will crash if the syscall fails

On Sun, 30 Aug 2020, Rich Felker wrote:

> > Tangentially, I'm not sure why this file has so many hardcoded magic
> > numbers and no comments to explain what they are.
> 
> Really it shouldn't even be external asm anymore. I'm trying to move
> as much external asm as possible to inline asm written in C, and this
> could be written entirely with __syscall() after #define
> SYSCALL_NO_TLS (recently added) and all the structures setup
> explicitly in C. I'll take a stab at doing that after fixing the bug.

I also would like an answer to a question about utter lack of comments
that your response did not directly address. This is an issue in
specialized asm implementations of math functions too, for instance.

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.