Date: Thu, 16 Apr 2020 11:05:36 -0500 From: <sidneym@...eaurora.org> To: "'Rich Felker'" <dalias@...c.org> Cc: <musl@...ts.openwall.com> Subject: RE: [hexagon] testing updates > -----Original Message----- > From: Rich Felker <dalias@...c.org> > Sent: Wednesday, April 15, 2020 10:16 PM > To: sidneym@...eaurora.org > Cc: musl@...ts.openwall.com > Subject: Re: [musl][hexagon] testing updates > > On Wed, Apr 15, 2020 at 10:10:20PM -0500, sidneym@...eaurora.org wrote: > > Updated alltypes.h.in and added sem.h. This change cleared the > > following > > errors: > > > > src/functional/pthread_mutex-static.exe > > > > src/functional/pthread_mutex.exe > > > > src/functional/pthread_mutex_pi-static.exe > > > > src/functional/pthread_mutex_pi.exe > > src/functional/sem_init-static.exe > > > > src/functional/sem_init.exe > > I'm confused how these changed at all from the changes you made. > sem_init is for POSIX semaphores not sysv ipc ones. The bits/sem.h things > don't have anything to do with it. The sem.h change shouldn't have been included in the patch. The change of time_t from a 64 to 32 bit value changed the size of timespec used in the pthread_cond and sem_timedwait I pruned our original port, possibly too much in some cases, but in this case I'd like some guidance since no other arch needed time_t as a 32-bit type. There is a large chunk of code compat/time32 which I have not tried to use yet but I have a feeling I might need to. > > > src/regression/pthread_cond-smasher-static.exe > > > > src/regression/pthread_cond-smasher.exe > > > > src/regression/pthread_cond_wait-cancel_ignored-static.exe > > > > src/regression/pthread_cond_wait-cancel_ignored.exe > > > > src/regression/pthread_once-deadlock-static.exe > > Likewise these shouldn't have changed either. If they did it's probably some > other hidden state in your test environment. > > > The patch is here: > > > https://github.com/quic/musl/commit/ca20acd472a8e9e58e584d51c4cd00ce > d6 > > f37087 > > The change to alltypes.h.in is wrong. It changes time_t to 32-bit, which is no > longer a supported configuration and not the intent. With that part reverted > and the sysvipc bits headers fixed as described before, I think you might > have it mostly working. > > Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.