Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 7 Feb 2020 16:03:31 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: fopen with "e" mode to close file descriptor in exec...
 functions

On Fri, Feb 07, 2020 at 09:22:01PM +0300, Alexander Scherbatiy wrote:
> Hello,
> 
> Below is a simple program without any errors handling that uses
> fopen with "ae" mode to open a "test.log" file with append access
> and call posix_spawn to create a child process and list all open files for
> the child process.
> 
> The program output shows that the child process has "test.log" file as open.
> I used docker with Alpine Linux 3.11.3 (musl libc x86_64 1.1.24).
> Is it an expected behaviour for Alpine Linux?
> 
> The same program on my Ubuntu 19.10 (with "ash" changed to "bash") shows
> that
> the child process doesn't have  "test.log" file as open.
> 
> Thanks,
> Alexander.
> 
> ----------  posix_spawn_sample.c ----------
> #include <stdlib.h>
> #include <stdio.h>
> #include <string.h>
> 
> #include <unistd.h>
> #include <spawn.h>
> #include <sys/wait.h>
> 
> extern char **environ;
> 
> int main()
> {
>     FILE* file = fopen("test.log", "ae");
>     fprintf(file, "test line\n");
> 
>     pid_t pid;
>     char *argv[] = {"bash", "-c", "echo PID=$$ && lsof -p $$", NULL};
>     int status = posix_spawn(&pid, "/bin/sh", NULL, NULL, argv, environ);
>     printf("Child pid: %i\n", pid);
>     waitpid(pid, &status, 0);
> 
>     fclose(file);
>     return 0;
> }
> --------------------------

I can't reproduce this. I had to change /bin/sh to /bin/bash to be
able to run the test at all, and the lsof I have (busybox) doesn't
support -p, but I can't see any indication that the child has the log
file open. I also tried changing it to run "ls -l /proc/$$/fd" in the
child, and a fd 3 shows up there but prints an error because fd 3 is
the directory fd for listing /proc/$$/fd and it's closed before trying
to stat it -- apparently ash execs ls rather than running it as a
child. Indeed adding "; echo" makes that go away.

If you're still having the problem, could you attach a log of running
your test under "strace -f"?

Rich

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.