Date: Wed, 29 Jan 2020 12:59:00 +0100 From: Sören Tempel <soeren@...ren-tempel.net> To: musl@...ts.openwall.com Subject: Re: [PATCH v2] cuserid: support invocation with a NULL pointer argument Sorry, forgot to confirm my list subscription before sending the first version of this patch. Just wanted to reply to a comment on the previous version: On Tue, 28 Jan 2020, Rich Felker wrote: > I'm not sure whether to adopt this or not, but thanks for posting on > the list for discussion. In any case it's something we should try to > get fixed in apps that are using it, since this is no longer portable > usage and is gratuitously thread-unsafe. From my personal Alpine Linux packaging perspective: I would prefer either removing the function entirely or supporting the invocation with a NULL pointer argument. Currently, apps using this with a NULL pointer (e.g. cdparanoia) will crash at runtime which makes it more difficult to identify them. If the function would be removed entirely we would be able to detect, during compilation, which apps use it and patch them accordingly. Cheers, Sören
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.