Date: Tue, 28 Jan 2020 09:59:56 +0100 From: Ben Noordhuis <info@...ordhuis.nl> To: musl@...ts.openwall.com Subject: Re: Re: [PATCH] add statx On Fri, Jan 24, 2020 at 3:01 PM Rich Felker <dalias@...c.org> wrote: > > On Fri, Jan 24, 2020 at 09:38:49AM +0100, Ben Noordhuis wrote: > > > > Can I get some feedback on this patch, even if it's just "no because"? Thanks. > > Sorry aboout that; I'd just had my mind on other things and hadn't > taken the time to make a good review yet. Thanks for the feedback and no worries, I'm no saint in that regard either. Before I post a v2, did I understand the following issues correctly? 1. Switch _GNU_SOURCE || _BSD_SOURCE -> just _GNU_SOURCE? FWIW, _BSD_SOURCE currently exposes the AT_STATX_* flags in fcntl.h. 2. uint64_t -> unsigned long long guarded by #ifdef __GNUC__ __extension__? Or just leave it as-is? 4. An ENOSYS fallback to fstatat()? glibc's fallback returns EINVAL for AT_* flags it doesn't understand and ignores all STATX_* flags: it sets stx_mask to STATX_BASIC_STATS, fills in stx_uid/stx_gid/etc. and sets stx_btime to zero. Does that sound reasonable?
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.