Date: Fri, 24 Jan 2020 17:12:51 +0100 From: Florian Weimer <fweimer@...hat.com> To: Rich Felker <dalias@...c.org> Cc: musl@...ts.openwall.com Subject: Re: [PATCH] add statx * Rich Felker: > On Fri, Jan 24, 2020 at 04:27:47PM +0100, Florian Weimer wrote: >> * Rich Felker: >> >> > This is under BSD||GNU (i.e. DEFAULT||ALL) rather than just under the >> > latter. Is there a reason for that? Generally the extensions that are >> > pretty clearly Linux-only, as opposed to something that other >> > POSIX-based OS's are likely to adopt, are put under GNU/ALL to >> > discourage their use without intent and to avoid namespace clutter. >> >> statx is not Linux-specific in glibc, but also available on Hurd. > > OK, well GNU/Linux-specific. :-) Some ppl find _GNU_SOURCE odd for > stuff that comes from Linux not GNU, but in this case it seems pretty > appropriate since GNU and Linux are the two systems doing it. Sorry for nit-picking, it's common to both GNU and Linux. gettid is Linux-specific, and so is pthread_getattr_default_np. pkey_set is something that is GNU/Linux-specific in the sense that is something that's only part of glibc, and only on Linux. >> We received feedback that our headers are not useful due to the >> __u64/uint64_t mismatch. >> >> <https://sourceware.org/bugzilla/show_bug.cgi?id=25292 >> <https://sourceware.org/ml/libc-alpha/2019-12/msg00631.html> > > Uhg. That change seems unfortunate since it's incompatible with > theoretical future archs having 128-bit long long -- an idea I'm not > much a fan of, but don't actually want to preclude. Is there a reason > to actually care about compatibility with the kernel types? Yes, printf format strings. 8-( > It's not like both struct definitions can be included in the same > source anyway; the tags would clash. Using the canonical uintN_t types > makes more sense from an API perspective, I think; kernel assumptions > about types should not leak into an API intended to be clean and > shared with non-Linux implementations. I thought so too, which is why I used them. But it is fairly compelling to use the kernel types if the header is available, so that we don't have to patch and rebuild glibc if someone backports new statx features into the kernel. That's why I added the __has_include kludge. Thanks, Florian
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.