Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 1 Jan 2020 15:47:31 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] mips: Use fpregset_t for fpregs element

On Wed, Dec 18, 2019 at 02:02:37PM -0800, Khem Raj wrote:
> it helps in fixing type errors seen in applications where the elements
> of mcontext_t fpregs is accessing struct elements by name
> 
> Signed-off-by: Khem Raj <raj.khem@...il.com>
> ---
>  arch/mips/bits/signal.h | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/bits/signal.h b/arch/mips/bits/signal.h
> index 1a84de59..e1d97ac7 100644
> --- a/arch/mips/bits/signal.h
> +++ b/arch/mips/bits/signal.h
> @@ -19,14 +19,18 @@ typedef struct {
>  } fpregset_t;
>  struct sigcontext {
>  	unsigned sc_regmask, sc_status;
> -	unsigned long long sc_pc, sc_regs[32], sc_fpregs[32];
> +	unsigned long long sc_pc;
> +	gregset_t sc_regs;
> +	fpregset_t sc_fpregs;
>  	unsigned sc_ownedfp, sc_fpc_csr, sc_fpc_eir, sc_used_math, sc_dsp;
>  	unsigned long long sc_mdhi, sc_mdlo;
>  	unsigned long sc_hi1, sc_lo1, sc_hi2, sc_lo2, sc_hi3, sc_lo3;
>  };
>  typedef struct {
>  	unsigned regmask, status;
> -	unsigned long long pc, gregs[32], fpregs[32];
> +	unsigned long long pc;
> +	gregset_t gregs;
> +	fpregset_t fpregs;
>  	unsigned ownedfp, fpc_csr, fpc_eir, used_math, dsp;
>  	unsigned long long mdhi, mdlo;
>  	unsigned long hi1, lo1, hi2, lo2, hi3, lo3;
> -- 
> 2.24.1

Merged.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.