Date: Wed, 25 Dec 2019 16:34:11 -0800 (PST) From: David Miller <davem@...emloft.net> To: AWilcox@...cox-Tech.com Cc: netdev@...r.kernel.org, linux-api@...r.kernel.org, musl@...ts.openwall.com Subject: Re: [PATCH] uapi: Prevent redefinition of struct iphdr From: "A. Wilcox" <AWilcox@...cox-Tech.com> Date: Sun, 22 Dec 2019 00:02:27 -0600 > @@ -83,6 +83,13 @@ > > #define IPV4_BEET_PHMAXLEN 8 > > +/* Allow libcs to deactivate this - musl has its own copy in <netinet/ip.h> */ > + > +#ifndef __UAPI_DEF_IPHDR > +#define __UAPI_DEF_IPHDR 1 > +#endif How is this a musl-only problem? I see that glibc also defines struct iphdr in netinet/ip.h, so why doesn't it also suffer from this? I find it really strange that this, therefore, only happens for musl and we haven't had thousands of reports of this conflict with glibc over the years. I want an explanation, and suitably appropriate adjustments to the commit message and comments of this change. Thank you.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.