[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
```Date: Wed, 11 Dec 2019 11:39:36 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: Stefan Kanthak <stefan.kanthak@...go.de>
Cc: musl@...ts.openwall.com
Subject: Re: [PATCH] fdim(), fdimf() and fdiml() radically simplified

* Stefan Kanthak <stefan.kanthak@...go.de> [2019-12-11 10:55:01 +0100]:
> Yet another optimisation/simplification in the math subtree.

these changes have incorrect fenv behaviour
(they signal the invalid exception on qnan input),
the result is fine though.

>
> JFTR: I'm NOT subscribed to your mailing list, so CC: me in replies!
>
> --- -/src/math/fdim.c
> +++ +/src/math/fdim.c
> @@ -3,8 +3,4 @@
>  double fdim(double x, double y)
>  {
> -        if (isnan(x))
> -                return x;
> -        if (isnan(y))
> -                return y;
> -        return x > y ? x - y : 0;
> +        return x <= y ? 0.0 : x - y;
>  }
>
> --- -/src/math/fdimf.c
> +++ +/src/math/fdimf.c
> @@ -3,8 +3,4 @@
>  float fdimf(float x, float y)
>  {
> -        if (isnan(x))
> -                return x;
> -        if (isnan(y))
> -                return y;
> -        return x > y ? x - y : 0;
> +        return x <= y ? 0.0 : x - y;
>  }
>
> --- -/src/math/fdiml.c
> +++ +/src/math/fdiml.c
> @@ -10,8 +10,4 @@
>  long double fdiml(long double x, long double y)
>  {
> -        if (isnan(x))
> -                return x;
> -        if (isnan(y))
> -                return y;
> -        return x > y ? x - y : 0;
> +        return x <= y ? 0.0 : x - y;
>  }
```

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.