Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [day] [month] [year] [list]
Date: Sun, 20 Oct 2019 04:37:59 +0000
From: "wangjianjian (C)" <>
To: "" <>
Subject: Re: [PATCH 1/1] ungetc: Cast to unsigned char before push

Thanks for review. I will send a v2.

>> I believe this is actually a functional change, and a needed one for
>> conformance (to ISO C, not specific to POSIX). The issue it seems to
Yes, I check ISO C standard. It also requires returning the character 
pushed back after conversion.

>> solve, which is what the change needs to be documented as, is the
>> return value when a negative value not equal to EOF is passed to
I don't quite understand. Do you mean we need document this change?
If so, where should I put it? Please tell me.

Wang Jianjian

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.