Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Fri, 18 Oct 2019 07:02:11 -0700
From: Dan Gohman <sunfish@...illa.com>
To: musl@...ts.openwall.com
Subject: [PATCH] Use fabsl instead of fabs on long double operand in floatscan.c

This fixes a compiler warning with clang:

floatscan.c:304:13: warning: absolute value function 'fabs' given an
argument of type 'long double' but has parameter of type 'double' which may
cause truncation of value [-Wabsolute-value].

This does change the behavior of the expression because the value is no
longer rounded to double, however from my reading of the code, the rounding
doesn't seem intended. However, if it is, I suggest introducing an explicit
cast, to document the intent.

Dan

Content of type "text/html" skipped

View attachment "0001-Use-fabsl-instead-of-fabs-on-long-double-in-floatsca.patch" of type "text/x-patch" (1059 bytes)

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.