Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 29 Sep 2019 16:56:39 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] remove remaining traces of __tls_get_new

On Sun, Sep 29, 2019 at 03:05:27PM +0200, Szabolcs Nagy wrote:
> reported on irc by malc_

> >From 4a7090ab76d81b59f57a83bce9d22582e35a8b2b Mon Sep 17 00:00:00 2001
> From: Szabolcs Nagy <nsz@...t70.net>
> Date: Sun, 29 Sep 2019 12:25:39 +0000
> Subject: [PATCH] remove remaining traces of __tls_get_new
> 
> Some declarations of __tls_get_new were left in the code, even
> though the definition got removed in
> 
>   commit 9d44b6460ab603487dab4d916342d9ba4467e6b9
>   install dynamic tls synchronously at dlopen, streamline access
> 
> this can make the build fail with
> 
>   ld: lib/libc.so: hidden symbol `__tls_get_new' isn't defined
> 
> when libc.so is linked without --gc-sections, because a .hidden
> declaration in asm code creates a reference even if the symbol
> is not actually used.

This is definitely a tooling bug. There is no reference to the symbol,
only declarations of it. I think it's a good idea to cleanup the
spurious mentions of it anyway, though.

Rich

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.