Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 18 Sep 2019 09:49:13 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] mips: add single-instruction math functions

On Wed, Sep 18, 2019 at 04:07:33PM +0300, info@...ile-stream.com wrote:
> >> diff --git a/src/math/mips/fabs.c b/src/math/mips/fabs.c
> >> new file mode 100644
> >> index 00000000..0a5aa3b1
> >> --- /dev/null
> >> +++ b/src/math/mips/fabs.c
> >> @@ -0,0 +1,16 @@
> >> +#if !defined(__mips_soft_float) && defined(__mips_abs2008)
> 
> R> Why is this dependent on __mips_abs2008?
> 
> 
> ABS.fmt is non-arithmetic only on cores with the corresponding FCSR
> bit hardwired to 1. It is R6 (always) and some R5 cores (such as
> P5600, M5150).

OK, in that case it may be okay to condition it on R6 (which is a
different ISA/ABI), as long as that's actually a hard requirement of
the R6 ISA.

Rich

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.