Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 10 Aug 2019 14:35:38 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com, Luiz Angelo Daros de Luca <luizluca@...il.com>
Subject: Re: dlsym returning unresolved symbol address instead of
 dependency library symbol address

* Szabolcs Nagy <nsz@...t70.net> [2019-08-10 12:11:11 +0200]:
> * Luiz Angelo Daros de Luca <luizluca@...il.com> [2019-08-10 05:16:19 -0300]:
> > I'm ruby maintainer in OpenWrt 18.06 (musl 1.1.19). I got a bug report (
> > https://github.com/openwrt/packages/issues/9297) related to musl in mipsel
...
> yes, if the search involves the main executable then
> st_shndx==0 && st_value!=0 symbols must be included
> because it's a plt in the exe and that's how function
> addresses work.. on most targets except mips.
> 
> undef syms have st_value==0 in shared libs, maybe
> not in mips? can you post the readelf -aW output of
> the module that has st_shndx==0 && st_value!=0 entry
> in its dynamic symbol table

ah i see in the bugreport

Buildx86$ staging_dir/toolchain-mips_24kc_gcc-7.3.0_musl/bin/mips-openwrt-linux-musl-readelf -s staging_dir/target-mips_24kc_musl/root-ar71xx/usr/lib/ruby/2.5/mips-linux-gnu/stringio.so | grep mall
91: 00004930 0 FUNC GLOBAL DEFAULT UND ruby_xmalloc
187: 00004930 0 FUNC GLOBAL DEFAULT UND ruby_xmalloc
    ^^^^^^^^^
st_value!=0

that is mips specific strangeness.

it's still not clear to me why is there different
code path between first vs second dlopen, but the
right fix to the reported issue is to reuse the
find_sym logic (since the executable case need not
be handled a somewhat simpler logic may work too,
but i'd prefer a single logic for dlsym and reloc
processing exactly because of broken elf targets
like mips that make maintenance of such code harder)

> 
> i think this was going to be fixed by
> https://www.openwall.com/lists/musl/2017/02/16/1/2
> but that was never applied.
> 
> > 
> > I created a simple patch that skips a symbol if it is undefined.
> > https://raw.githubusercontent.com/luizluca/openwrt/b9674d528513c7c93205fa000fed7c0d3c6bb2e7/toolchain/musl/patches/020-dlsym_donot_return_address_from_undef_sym.patch
> > 
> 
> i think the find_sym logic should be copied
> because mips behaves differently from other targets:
> 
> http://git.musl-libc.org/cgit/musl/commit/?id=2d8cc92a7cb4a3256ed07d86843388ffd8a882b1
> 
> 
> > It fixes the issue and it did not break my system(it still boots). However,
> > I didn't test it with multiples archs nor I runned an extensive test.
> > 
> > I'm not subscribed. Please, CC me.
> > 
> > Regards,
> > ---
> >      Luiz Angelo Daros de Luca
> >             luizluca@...il.com

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.