[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 22 Jul 2019 13:50:07 -0500
From: "A. Wilcox" <awilfox@...lielinux.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 1/5] fix warning dangling-else
On 07/22/19 13:07, Issam Maghni wrote:
> Signed-off-by: Issam Maghni <me@...cati.me>
> ---
> src/ctype/towctrans.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/ctype/towctrans.c b/src/ctype/towctrans.c
> index 8f681018..bd0136dd 100644
> --- a/src/ctype/towctrans.c
> +++ b/src/ctype/towctrans.c
> @@ -259,12 +259,14 @@ static wchar_t __towcase(wchar_t wc, int lower)
> || (unsigned)wc - 0xabc0 <= 0xfeff-0xabc0)
> return wc;
> /* special case because the diff between upper/lower is too big */
> - if (lower && (unsigned)wc - 0x10a0 < 0x2e)
> + if (lower && (unsigned)wc - 0x10a0 < 0x2e) {
> if (wc>0x10c5 && wc != 0x10c7 && wc != 0x10cd) return wc;
> else return wc + 0x2d00 - 0x10a0;
> - if (!lower && (unsigned)wc - 0x2d00 < 0x26)
> + }
> + if (!lower && (unsigned)wc - 0x2d00 < 0x26) {
> if (wc>0x2d25 && wc != 0x2d27 && wc != 0x2d2d) return wc;
> else return wc + 0x10a0 - 0x2d00;
> + }
> if (lower && (unsigned)wc - 0x13a0 < 0x50)
> return wc + 0xab70 - 0x13a0;
> if (!lower && (unsigned)wc - 0xab70 < 0x50)
>
I know none of these changes have a chance of making it in, but this one
specifically *does* genuinely irk me and I *would* love to see this one
actually merged to musl.
--arw
--
A. Wilcox (awilfox)
Project Lead, Adélie Linux
https://www.adelielinux.org
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
