Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 14 Feb 2019 19:55:50 -0600
From: "A. Wilcox" <>
Subject: Re: [PATCH] eliminate strict parentheses warnings for

On 02/14/19 18:24, Nick Bray wrote:
> Patch is attached.
> The change was motivated by including Musl's headers from a project
> with -Werror -Wall enabled. I believe Fucshia ran into this, too.  I
> couldn't think of a good regression test, in part because warnings are
> somewhat compiler specific.  One possible approach would be to enable
> -Werror -Wall in the main build, but that runs into issues of which
> compilers are supported and what the core developers prefer.  Another
> approach would be to only lint the header files - generate a dummy .c
> file that includes all the header files and compile it with -Werror.
> This is complicated by the "redirection" header files that warn you
> should use the canonical version.  Which header files should be
> checked?  So for the moment I punted on regression testing.  I mention
> this line of thinking in case anyone has some perspective. 

This has a strong +1 from me, but changes like this have already been
rejected at least twice on this list because "compilers shouldn't warn
about system headers".

Perhaps at attempt #3, they will just accept that this happens regularly
enough that a few parens is not the end of the world.  (It also makes
more components of musl reusable in other libraries, if desired.)


A. Wilcox (awilfox)
Project Lead, Adélie Linux

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.