Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Tue, 12 Feb 2019 09:35:22 -0600
From: "A. Wilcox" <AWilcox@...cox-Tech.com>
To: musl@...ts.openwall.com
Cc: "A. Wilcox" <AWilcox@...cox-Tech.com>
Subject: [PATCH] powerpc64: use a type for mcontext_t regs field

GCC Go dereferences `regs` for `nip`.  Without this change, compilation
fails with the following message:

../../../libgo/runtime/go-signal.c: In function ‘getSiginfo’:
../../../libgo/runtime/go-signal.c:225:56: warning: dereferencing ‘void *’ pointer
  ret.sigpc = ((ucontext_t*)(context))->uc_mcontext.regs->nip;
                                                        ^~
../../../libgo/runtime/go-signal.c:225:56: error: request for member ‘nip’ in something not a structure or union
---
 arch/powerpc64/bits/signal.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc64/bits/signal.h b/arch/powerpc64/bits/signal.h
index 34693a68..6736c69a 100644
--- a/arch/powerpc64/bits/signal.h
+++ b/arch/powerpc64/bits/signal.h
@@ -8,6 +8,8 @@
 
 #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
 
+#include <bits/user.h>
+
 typedef unsigned long greg_t, gregset_t[48];
 
 typedef struct {
@@ -29,7 +31,7 @@ typedef struct sigcontext {
 	int _pad0;
 	unsigned long handler;
 	unsigned long oldmask;
-	void *regs;
+	struct pt_regs *regs;
 	gregset_t gp_regs;
 	fpregset_t fp_regs;
 	vrregset_t *v_regs;
-- 
2.19.2

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.