Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 16 Nov 2018 16:36:06 -0500
From: Rich Felker <>
	Rafał Miłecki <>
Subject: Re: Re: [PATCH libc-test] add strptime basic test

On Thu, Nov 15, 2018 at 10:26:58PM +0100, Szabolcs Nagy wrote:
> * Rafał Miłecki <> [2018-11-15 11:12:34 +0100]:
> > It also fails with:
> > 
> > "%F": failed to parse "1856-07-10"
> > "%s": failed to parse "683078400"
> > "%z": failed to parse "+0200"
> > "%z": failed to parse "-0530"
> > "%z": failed to parse "-06"
> > 
> > but that's expected due to unimplemented %F %s and %z.
> v2 looks good, but these are testing extensions.
> do you intend to add patch for %F and %s too?
> if not i'll disable those tests

I think it's a good idea to keep tests for standards-mandated behavior
separate from tests for extensions, even if we do want to support the
latter in musl, and name them appropriately. It matters if/when people
use libc-test to assess the conformance of another implementation that
may not have made the same choices about extensions.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.