Date: Wed, 25 Oct 2017 12:56:42 -0400 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: Build failure on ARM <5 On Fri, Oct 20, 2017 at 05:26:14PM -0400, Rich Felker wrote: > On Fri, Oct 20, 2017 at 09:36:45PM +0200, Szabolcs Nagy wrote: > > * Reiner Herrmann <reiner@...ner-h.de> [2017-10-20 21:04:00 +0200]: > > > Hi, > > > > > > musl 1.1.17 fails to build  on arm versions <5 because > > > of an unsupported clz instruction. > > > The attached patch by Adrian Bunk  fixes this issue. > > > > > > > this is my bug sorry, > > > > > diff --git a/arch/arm/atomic_arch.h b/arch/arm/atomic_arch.h > > > index a121010f..c5c56f81 100644 > > > --- a/arch/arm/atomic_arch.h > > > +++ b/arch/arm/atomic_arch.h > > > @@ -82,9 +82,13 @@ static inline void a_crash() > > > : : : "memory"); > > > } > > > > > > +#if __ARM_ARCH >= 5 > > > + > > > > this is not enough: v5t and v6 only supports clz in arm mode > > v6t2 and v7 supports it in thumb mode too. > > I don't think this matters yet because thumb1 is not supported at all. > If we support it in the future it will matter, though. After discussion on #musl, committed with additional notes on the regression and limitations of the fix, and credit to the patch author. Thanks. Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.