Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170628132513.15483-1-amonakov@ispras.ru>
Date: Wed, 28 Jun 2017 16:25:13 +0300
From: Alexander Monakov <amonakov@...ras.ru>
To: musl@...ts.openwall.com
Subject: [PATCH] fix undefined behavior in ptrace

---
 src/linux/ptrace.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/linux/ptrace.c b/src/linux/ptrace.c
index 83b8022b..ab7fcda3 100644
--- a/src/linux/ptrace.c
+++ b/src/linux/ptrace.c
@@ -7,14 +7,17 @@ long ptrace(int req, ...)
 {
 	va_list ap;
 	pid_t pid;
-	void *addr, *data, *addr2;
+	void *addr, *data, *addr2 = 0;
 	long ret, result;
 
 	va_start(ap, req);
 	pid = va_arg(ap, pid_t);
 	addr = va_arg(ap, void *);
 	data = va_arg(ap, void *);
+	/* PTRACE_{READ,WRITE}{DATA,TEXT} are specific to SPARC. */
+#ifdef PTRACE_READTEXT
 	addr2 = va_arg(ap, void *);
+#endif
 	va_end(ap);
 
 	if (req-1U < 3) data = &result;
-- 
2.11.0

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.