Date: Fri, 23 Jun 2017 15:37:38 -0400 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: Ignored patch On Fri, Jun 23, 2017 at 02:27:41PM +0300, Dmitry Golovin wrote: > I have already posted this patch on this mailing list (the original > subject was "Proper warning silencing patch for Clang"), but I > didn't get any feedback about it. Maybe it is not formatted properly > or there is some other problem with it. Please let me know if > something is wrong with this patch. > > Regards, > Dmitry > From c37efc541b12d8e216b7a425808e4c24c48f9213 Mon Sep 17 00:00:00 2001 > From: Dmitry Golovin <dima@...ovin.in> > Date: Fri, 9 Jun 2017 16:41:53 +0300 > Subject: [PATCH] add proper check for clang supported optimization and stop > complaining about unused arguements > > --- > configure | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/configure b/configure > index c2db298..539c9fc 100755 > --- a/configure > +++ b/configure > @@ -249,6 +249,7 @@ fi > # > tryflag CFLAGS_TRY -Werror=unknown-warning-option > tryflag CFLAGS_TRY -Werror=unused-command-line-argument > +tryflag CFLAGS_TRY -Werror=ignored-optimization-argument > tryldflag LDFLAGS_TRY -Werror=unknown-warning-option > tryldflag LDFLAGS_TRY -Werror=unused-command-line-argument > > @@ -504,6 +505,13 @@ tryflag CFLAGS_AUTO -Werror=implicit-int > tryflag CFLAGS_AUTO -Werror=pointer-sign > tryflag CFLAGS_AUTO -Werror=pointer-arith > > +# > +# GCC ignores unused arguements by default, but Clang needs this extra > +# parameter to stop printing warnings about LDFLAGS passed during > +# compiling stage and CFLAGS passed during linking stage. > +# > +tryflag CFLAGS_AUTO -Qunused-arguments > + > if test "x$warnings" = xyes ; then > tryflag CFLAGS_AUTO -Wall > tryflag CFLAGS_AUTO -Wno-parentheses > -- > 2.13.0 > I think this looks good; I've just been trying to get through patch backlog while new ones keep coming in. I'll try it and make sure it seems to behave okay on a system with clang soon and commit it if nothing goes wrong. Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.