Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 15 Jun 2017 20:03:30 +0300 (MSK)
From: Alexander Monakov <amonakov@...ras.ru>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] Handle localtime errors in ctime

On Thu, 15 Jun 2017, Rich Felker wrote:
> On Thu, Jun 15, 2017 at 07:43:36PM +0300, Omer Anson wrote:
> > ctime passes the result from localtime directly to asctime. But in case
> > of error, localtime returns 0. This causes an error (NULL pointer
> > dereference) in asctime.
> > 
> > According to the man pages [1], ctime should also return 0 upon error.
> > Therefore, if localtime fails (return 0), ctime also returns 0.
> > 
> > [1] https://linux.die.net/man/3/ctime

> Content looks good. Making minor edits for style and I'll commit.

Um, the previous time an opposite direction was taken:
http://www.openwall.com/lists/musl/2014/09/05/17

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.