Date: Sun, 28 May 2017 17:06:45 +0200 From: Julien Ramseier <j.ramseier@...il.com> To: musl@...ts.openwall.com Subject: Re: [PATCH] glob: fix / matching > Le 28 mai 2017 à 04:55, Rich Felker <dalias@...c.org> a écrit : >> >> I'm confused how this patch differs from just removing the "if (*p)" >> condition before calling match_in_dir. Does match_in_dir actually work >> if p points to an empty string? I thought not... > > Hmm, just removing the "if (*p)" seems to make it work; it looks like > match_in_dir covers this case fine. I'd like a second opinion on > whether this looks okay since I haven't touched this code in years, > but I suspect it'll turn out to be an okay fix for now... > The "if (*p)" is needed, otherwise match_in_dir will append an empty match when p = "". - Julien Content of type "text/html" skipped
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.