|
|
Message-ID: <69525bd8-5c0b-be06-39db-35fa0e04f7ba@unixsol.org>
Date: Tue, 25 Apr 2017 22:03:08 +0300
From: Georgi Chorbadzhiyski <gf@...xsol.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH v2] Add RES_OPTIONS support for resolv.conf options
overriding
On 4/25/17 9:26 PM, Stefan Sedich wrote:
> On Tue, Apr 25, 2017 at 11:20 AM Georgi Chorbadzhiyski <gf@...xsol.org <mailto:gf@...xsol.org>> wrote:
>
> On 4/25/17 8:02 PM, Stefan Sedich wrote:
> > + char *res_opts_env;
> > + if (!libc.secure) res_opts_env = getenv("RES_OPTIONS");
> > + if (res_opts_env) {
>
> It seems to me that 'res_opts_env' is not guaranteed to be initialized
> in case libc.secure is set.
>
> > + __parse_resolv_opts(conf, res_opts_env);
> > + }
> > +
> > return 0;
> > }
>
>
> Will initializing res_opts_env to 0 be enough here?
I think
char *res_opts_env = NULL;
would do the trick.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.