Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 19 Jan 2017 22:50:19 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 2/2] Fix digit offset on resolv.conf attempts.

On Thu, Jan 19, 2017 at 09:49:08PM +0000, KARL BIELEFELDT wrote:
> ---
>  src/network/resolvconf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/network/resolvconf.c b/src/network/resolvconf.c
> index 2cf1f475..4c3e4c4b 100644
> --- a/src/network/resolvconf.c
> +++ b/src/network/resolvconf.c
> @@ -45,8 +45,8 @@ int __get_resolv_conf(struct resolvconf *conf, char *search, size_t search_sz)
>  				if (z != p) conf->ndots = x > 15 ? 15 : x;
>  			}
>  			p = strstr(line, "attempts:");
> -			if (p && isdigit(p[6])) {
> -				p += 6;
> +			if (p && isdigit(p[9])) {
> +				p += 9;
>  				unsigned long x = strtoul(p, &z, 10);
>  				if (z != p) conf->attempts = x > 10 ? 10 : x;
>  			}

This looks correct. Would you like to be credited as commit author? (I
usually ask for new first-time contributors before putting name/email
in permanent repo history.)

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.