Date: Tue, 8 Mar 2016 00:05:27 -0500 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: [PATCH] Define LONG_DOUBLE_IS_* internal macros. On Tue, Mar 08, 2016 at 11:38:15AM +0900, OGINO Masanori wrote: > These macros indicate which format is used for long double with the > toolchain. > > Although the meaning of "LDBL_DIG_MANT == 64 && LDBL_MAX_EXP == 16384" > is very clear to floating-point arithmetic guys, it is nice to have > descriptive names to such conditions. I understand where you're coming from but I think this is opposite to the style preferences in musl, which are to avoid dependence on internal things and directly use portable conditions based on public interfaces where possible. The existing tests are all completely valid even outside musl, without depending on any musl-internal stuff. If the intent is not clear, perhaps some simple comments would suffice? Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.