Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 29 Feb 2016 15:05:00 -0500
From: Rich Felker <>
Subject: Re: [PATCH] add sched_getcpu

On Mon, Feb 29, 2016 at 10:59:10PM +0300, Alexander Monakov wrote:
> On Mon, 29 Feb 2016, Rich Felker wrote:
> > > (this include could also be dropped; I think it's a matter of policy whether
> > > such includes are desirable or not, so please wait for comment from Rich)
> > 
> > Policy is to always include the header with the public declaration
> > (and any feature test macros necessary to get it) so that the compiler
> > checks the implementation against the public declaration.
> This policy certain makes sense; I pointed that out because I've seen it
> violated; at least the following files violate it by defining something
> without including anything:

Thanks for tracking these down. See below:

> arch/arm/src/__aeabi_atexit.c

This ia an ABI function but has no public declaration and is not
callable as API.

> src/internal/procfdname.c

This is an internal function.

> src/misc/gethostid.c

Should be fixed to include unistd.h.

> src/prng/__seed48.c
> src/signal/restore.c


> src/signal/sigrtmin.c

ABI but the symbol is exposed via a public macro in signal.h so I
think we should include the header.

> src/stdlib/abs.c
> src/stdlib/labs.c
> src/stdlib/llabs.c

Definitely should include header.

> src/time/__month_to_secs.c
> src/time/__year_to_secs.c



Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.