Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 4 Feb 2016 18:52:47 -0500
From: Rich Felker <>
To: Mahesh Bodapati <>
Cc: Szabolcs Nagy <>,
	Jaydeep Patil <>,
	Anand Takale <>,
Subject: Re: Re: mips n64 porting review

On Wed, Feb 03, 2016 at 06:36:57PM -0500, Rich Felker wrote:
> On Wed, Feb 03, 2016 at 03:41:13PM +0000, Mahesh Bodapati wrote:
> > Hi Rich,
> > I have attached the patch which has all the MIPS n64 porting work. I
> > have created mips64port remote branch on GitHub and the repository
> > is which has
> > the broken down patches and the base revision on which I have
> > prepared patch is v1.1.12-41-g3abb094.
> Some preliminary review:

One more thing that came up in reviewing syscall_cp.s was actually a
bug copied from existing code in musl, which is fixed by this commit:

In practice the code seemed to work but it was wrong with respect to
ABI requirements.

I think the way you're saving $gp on the stack in sigsetjmp.s is also
invalid since that part of the stack will have been clobbered by the
time setjmp returns a second time. You could save it inside an unused
part of the jump buffer, but it might be better to just avoid the $gp
register and instead use temp registers and possibly some pc-relative
address computations.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.