Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 24 Jan 2016 00:05:36 +0300 (MSK)
From: Alexander Monakov <>
cc: Hauke Mehrtens <>
Subject: Re: [PATCH] Add format attribute to some function

On Sat, 23 Jan 2016, Hauke Mehrtens wrote:

> GCC and Clang are able to check the format arguments given to a
> function and warn the user if there is a error in the format arguments
> or if there is a potential uncontrolled format string security problem
> in the code. GCC does this automatically for some functions like
> printf(), but it is also possible to annotate other functions in a way
> that it will check them too. This feature is used by glibc for many
> functions. This patch adds the attribute to the some functions of musl
> expect for these functions where gcc automatically adds it.

Here's how a similar change was done the last time around:

Note that that approach avoids repeating #ifdef __GNUC__ ...

How did you choose which functions from stdio.h to annotate?  Are you saying
that gcc is unaware of snprintf while it recognizes sprintf?


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.