Date: Sat, 2 Jan 2016 23:24:54 -0500 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: [PATCH] netinet/tcp: Add TCPOPT, TCPOLEN constants On Sat, Jan 02, 2016 at 08:15:16PM +0100, Shiz wrote: > > > On 02 Jan 2016, at 03:18, Kylie McClain <somasissounds@...il.com> wrote: > > > > I've attached it since I don't trust gmail to not mess up patch > > formatting. > > This seems off: > > >+#ifdef defined(_BSD_SOURCE) > > I think you either want #ifdef _BSD_SOURCE or #if defined(_BSD_SOURCE) here. Yes. Also, due to the way things currently work, I think it's necessary to test defined(_BSD_SOURCE) || defined(_GNU_SOURCE). I don't like that and want to fix it at the features.h level, but this is an overhaul fix that should be made all at once rather than with incremental inconsistency, so for now it's best to just test both here, I think. Also, it seems there's already a section later in the file that's conditional on BSD||GNU, so unless there's a good conceptual reason not to I'd probably rather add the new constants there. Does this sound okay? Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.