[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 26 Oct 2015 20:10:22 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] getnameinfo: make size check not fail for bigger
sizes
On Mon, Oct 26, 2015 at 11:03:55PM +0100, Hauke Mehrtens wrote:
> getnameinfo() compares the size of the given struct sockaddr with
> sizeof(struct sockaddr_in) and sizeof(struct sockaddr_in6) depending on
> the net family. When you add a sockaddr of size sizeof(struct
> sockaddr_storage) this function will fail because the size of the
> sockaddr is too big. Change the check that it only fails if the size is
> too small, but make it work when it is too big for example when someone
> calls this function with a struct sockaddr_storage and its size.
> This fixes a problem with IoTivity 1.0.0 and musl.
>
> glibc and bionic are only failing if it is smaller, net/freebsd
> implemented the != check.
>
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
Applied. Thanks!
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
