Date: Thu, 8 Oct 2015 17:37:21 -0400 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: [PATCH 1/5] Pull a couple common AWK functions for CFI scripts into separate file On Fri, Oct 02, 2015 at 01:32:32PM +0200, Alex Dowad wrote: > There is a lot which could be common between i386 and x86_64, but none of it > will be useful for any other arch. These should be useful for all archs, > however. > --- Thanks! I'm commenting on these as a set rather than breaking this down into separate replies. I think you still have errors in your instruction parsing which will lead to incorrect clobbers, just not as bad as before. For example, movl $0,(%esp,%esi) gets marked as clobbering %esi. Using .* in the patterns is probably a bad idea. I think the x86_64 patch is also affected, but I tested it and otherwise it basically works. In any case I'm going ahead and applying patches 1-3, with 2 and 3 merged into one commit. In general, try to merge changes that are conceptually related and where putting them together in one patch doesn't obscure what was changed; for example, merging 4 with 2-3 would obscure changes IMO since there would be pattern changes and operand order changes in the same lines. I've also edited commit messages to match capitalization used in shortlog and to make git log fit in 80 columns (generally messages should be wrapped at 70-72 chars, like email). Could you follow up with fixes for patches 4 and 5? I'd like to try to get these into the next release (soon). Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.