Date: Wed, 1 Jul 2015 19:04:15 -0400 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: [PATCH] socket.h: fix SO_* for mips On Thu, Jul 02, 2015 at 12:14:58AM +0300, Roman Yeryomin wrote: > On Wed, Jul 1, 2015 at 11:16 PM, Szabolcs Nagy <nsz@...t70.net> wrote: > > * Roman Yeryomin <roman@...t.com> [2015-07-01 19:27:08 +0300]: > >> Signed-off-by: Roman Yeryomin <roman@...t.com> > >> --- > >> arch/mips/bits/socket.h | 31 ++++++++++++++++++------------- > >> arch/powerpc/bits/socket.h | 9 ++++++--- > >> include/sys/socket.h | 6 +++--- > >> 3 files changed, 27 insertions(+), 19 deletions(-) > >> > > > >> +#define SO_ACCEPTCONN 0x1009 > >> +#define SO_PROTOCOL 0x1028 > >> +#define SO_DOMAIN 0x1029 > > > > i assume these 3 were wrong in generic sys/socket.h > > and eveything else is ok, just reordered > > > > Yes, these 3 are added to mips, powerpc and put under ifdef in > sys/socket.h to avoid redefines. > Other changes in mips bits/socket.h is reordering and rewriting in hex > to be somewhat consistent and easily comparable with asm/socket.h OK. I think it would be good to factor this into two patches then: one that makes the minimal change to fix the values, and another that's pure cleanup for consistency and reordering. I'm somewhat skeptical of the value of cleanup since this is all scheduled for overhaul soon, but "soon" keeps getting pushed back so in the mean time maybe it's nice to have some cleanup anyway. :-) Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.