Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 1 Jul 2015 15:41:06 -0400
From: Rich Felker <>
Subject: Re: [PATCH] socket.h: fix SO_* for mips

On Wed, Jul 01, 2015 at 07:27:08PM +0300, Roman Yeryomin wrote:
> Signed-off-by: Roman Yeryomin <>
> ---
>  arch/mips/bits/socket.h    | 31 ++++++++++++++++++-------------
>  arch/powerpc/bits/socket.h |  9 ++++++---
>  include/sys/socket.h       |  6 +++---
>  3 files changed, 27 insertions(+), 19 deletions(-)

As written, the patch makes a lot of reorderings and 'gratuitous'
changes (like 8 -> 0x0008) that make it hard to understand what's
actually wrong. Could you provide a list of the values that were wrong
before and what they should be?

And is the powerpc part just adding copies of the default definitions
since some defaults in sys/socket.h are moved inside #if... ?


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.