Date: Sat, 27 Jun 2015 22:58:58 -0400 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: [PATCH v9] Build process uses script to add CFI directives to x86 asm On Wed, Jun 24, 2015 at 07:33:54AM +0200, Alex wrote: > On Tue, Jun 23, 2015 at 11:52 PM, Rich Felker <dalias@...c.org> wrote: > > > On Tue, Jun 23, 2015 at 09:18:08PM +0200, Alex Dowad wrote: > > > ../configure now checks CFLAGS as well as CFLAGS_AUTO to see if > > generation of debug > > > info was requested. > > > > > > The idea of removing duplication from the Makefile using a new AS_CMD > > variable has > > > come up several times, but this will not work because the arguments need > > to be > > > inserted in different places. I have tried using a Makefile 'define' > > instead. > > > Please see whether you like the way this code reads or not. > > > > > > Subarch asm files are treated the same as other asm files. Please note > > that > > > since I don't own the hardware, I can't test whether these Makefile > > rules work or not. > > > > I should have mentioned -- the CFLAGS_ALL_STATIC/_SHARED variants are > > meaningless to asm, so it would work fine to just use $(CFLAGS_ALL); > > then there's no need for fancy tricks, and a simple make variable > > should work, I think. > > A simple make variable works for the non-subarch rules. But what to do for > the subarch rules, which use $(dir $<)$(shell cat $<)? Thanks for clarifying. This made sense as soon as I read your email, but I didn't reply right away because I didn't have any better ideas, and right now I still don't. So perhaps we should just go with this for now. At some point I'd like to remove the existing use of "make functions" like this, and this new one if we've added it -- they're obstacles to being able to use a new make utility such as a hypothetical toybox one -- but for now it's no worse than the dependency we already have. Anyway, I think this is still on-track for making it into the release. I want to do some brief testing but if nothing else comes up I think it's ready to commit. Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.