Date: Tue, 28 Apr 2015 09:46:47 -0400 From: Rich Felker <dalias@...c.org> To: musl@...ts.openwall.com Subject: Re: Pending patches & other changes On Tue, Apr 28, 2015 at 11:43:21AM +0200, Szabolcs Nagy wrote: > * Rich Felker <dalias@...c.org> [2015-04-27 23:48:20 -0400]: > > Here is a list of patches I'm aware of that have been sent to the list > > that I haven't yet applied or rejected: > > > > [PATCH] generate debug_frame info for __syscall_cp_asm (i386) so gdb can get backtrace > > [PATCH] fmtmsg: verify that label is in the correct format. > > [PATCH] replace 'hlt' by 'ud2' in i386/x32/x86_64 a_crash implementations > > [PATCH] conforming strverscmp() implementation > > > > There are also a few patches from nsz on the radar: > > > > http://port70.net/~nsz/musl/0001-add-IPTOS_CLASS_-macros-to-netinet-ip.h.patch > > http://port70.net/~nsz/musl/0001-complex-fix-ctanh-0-i-nan-and-ctanh-0-i-inf.patch > > http://port70.net/~nsz/musl/0001-inet_pton-clean-up.patch > > > > and the BRE extensions that are still under discussion, and possibly > > some cleanup of some always-false null checks in the failure path of > > regcomp. > > > > There's also the idea of changing getlogin[_r] to probe the actual > > controlling terminal and its owner to get the "logged in user" rather > > than just using $LOGNAME. I've done some work on this but it's not > > done and not clean for commit. > > > > Anything else I'm missing? Most of this probably won't go in the > > release but I at least want to make sure we have a good inventory of > > what's still pending. > > > > i forgot to do this one in elf.h: > > -#define SHF_EXCLUDE (1 << 31) > +#define SHF_EXCLUDE (1U << 31) > > (there is no other invalid <<31) This was discussed quite a bit on libc-alpha (glibc list) and it seems the consensus there is that changing the type to unsigned is potentially dangerous and it would be better to use (-0x7fffffff-1) or perhaps ((1<<30) * -2) if it's more clear. What do you think? Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.