Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Tue, 21 Apr 2015 19:28:30 +0300 (MSK)
From: Alexander Monakov <>
Subject: Static analysis results

New round of static analysis results.  This time it's mostly opportunities for
very minor cleanups (I'm showing only a few results that I think make sense).
If there's a problem in balance of usefulness vs annoyance, please let me know.

  'if (runtime)' is already established as true at line 337

  I didn't try to follow the code in detail, but it seems possible that 'goto
  fail' can be executed from e.g. line 133 after successful mmap, in which
  case the region is not unmapped

  neither of the conditions cannot hold

  the first two conditions cannot hold after check at line 1489 and exit at
  line 1501

  F_SETLKW is already taken care of at line 16
  also, why does this file cast arg to 'void *' in several places?

  condition 'stack != NULL' cannot hold

  on 64-bit arches, multiplication can overflow in 32-bit type before assignment 


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.