[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141101162230.GH10829@port70.net>
Date: Sat, 1 Nov 2014 17:22:30 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Cc: Rich Felker <dalias@...c.org>
Subject: Re: the prototype decl of memcpy/memcmp/calloc/free
shouldnot in sched.h
* ????????? <jianzhong.huang@...oft.com.cn> [2014-10-31 11:42:35 +0800]:
>
> In firefox, there is a system_wrapper header include sched.h, but in hunspell codes, calloc and free was redefined, so there is a conflicts here.
> for example, in "extensions/spellcheck/hunspell/src/hunspell_alloc_hooks.h"
> #define calloc(count, size) HunspellAllocator::CountingCalloc(count, size)
>
a simple fix for that in musl is
void *(calloc)(size_t, size_t);
or
#define CPU_ALLOC(n) __cpu_alloc(n)
static __inline cpu_set_t *__cpu_alloc(size_t _n)
{
extern void *(calloc)(size_t,size_t);
return (calloc)(1,CPU_ALLOC_SIZE(_n));
}
which almost gets the namespace right: only a non-function like
calloc macro defined before sched.h would be an issue
getting the namespace completely right would need a new extern
identifier in musl that aliases or wraps calloc
but _GNU_SOURCE has no well defined namespace requirement
so it is hard to justify workarounds that spill over into
other parts of the libc
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
