Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 29 Jul 2014 20:55:44 -0400
From: Rich Felker <>
Subject: Re: Reviewing if_nameindex and getifaddrs patch

On Tue, Jul 29, 2014 at 10:49:43AM -0400, Rich Felker wrote:
> On Mon, Jul 28, 2014 at 11:13:27AM +0300, Timo Teras wrote:
> > On Sun, 27 Jul 2014 20:49:06 -0400
> > Rich Felker <> wrote:
> > 
> > > In regards to:
> > > 
> > >
> > 
> > Updated patch in the end.
> I can't get the patch to apply. Not sure whether email ate it or if
> there's an underlying problem.

Based on the version of this patch re-sent off-list, which I'm
attaching, I've reviewed it and fixed up a few remaining issues:

- Missing pthread_setcancelstate in if_nameindex.
- Possibly wrong errno from if_nameindex (needs to set ENOBUFS).

With these changes I'm committing it; we can make further improvements
later if needed. Perhaps getifaddrs should also avoid being
cancellable, but it's non-POSIX and thus this isn't really specified,
and the old one was already cancellable so there's no regression.

Thanks for working on this and being patient.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.