Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 21 Jun 2014 00:46:26 -0400
From: Rich Felker <>
Subject: Re: [PATCH v3] Implement fmtmsg

On Fri, Jun 20, 2014 at 07:32:01AM -0700, Isaac Dunham wrote:
> Here's a third revision of fmtmsg.

Thanks, it looks good. I'm doing a bit of cleanup before I commit --
mostly things like mismatches spaces/tabs in indention/alignment,
trailing spaces, etc. Also taking out the useless if around the while
loop that contains the if condition as part of the while condition,
debloating the header a bit (all the hex constants), adding protection
against pthread cancellation, and fixing one error in the header:
0xffffffff is not a valid value for MM_NOTOK since it doesn't fit in

I'm a bit tired now so rather than just commit and possibly have
stupid mistakes, I'm sending my draft revisions here (attached). If
you get a chance please take a look and see if they look ok.



View attachment "fmtmsg.c" of type "text/plain" (2467 bytes)

View attachment "fmtmsg.h" of type "text/plain" (742 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.