[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20131105233148.GJ24286@brightrain.aerifal.cx>
Date: Tue, 5 Nov 2013 18:31:48 -0500
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: [PATCH v2] shadow: Implement putspent
On Tue, Nov 05, 2013 at 02:30:00PM -0800, Michael Forney wrote:
> ---
> Thanks Rich,
>
> I didn't know about negative and zero precision specifiers. This turned out
> much cleaner.
>
> I've also changed the fields to use %ld because they are longs, and changed the
> last field to %lu because it is unsigned (though unused).
Thanks.
> src/passwd/fgetspent.c | 5 -----
> src/passwd/putspent.c | 13 +++++++++++++
> 2 files changed, 13 insertions(+), 5 deletions(-)
> create mode 100644 src/passwd/putspent.c
>
> diff --git a/src/passwd/fgetspent.c b/src/passwd/fgetspent.c
> index a9a3c97..3dda784 100644
> --- a/src/passwd/fgetspent.c
> +++ b/src/passwd/fgetspent.c
> @@ -4,8 +4,3 @@ struct spwd *fgetspent(FILE *f)
> {
> return 0;
> }
> -
> -int putspent(const struct spwd *sp, FILE *f)
> -{
> - return -1;
> -}
> diff --git a/src/passwd/putspent.c b/src/passwd/putspent.c
> new file mode 100644
> index 0000000..fbf4278
> --- /dev/null
> +++ b/src/passwd/putspent.c
> @@ -0,0 +1,13 @@
> +#include <shadow.h>
> +#include <stdio.h>
> +
> +#define NUM(n) (n == -1 ? 0 : -1), (n == -1 ? 0 : n)
> +#define STR(s) (s ? s : "")
While it doesn't really matter in this file, in general, macro
arguments should be properly parenthesized, as in:
+#define NUM(n) ((n) == -1 ? 0 : -1), ((n) == -1 ? 0 : (n))
+#define STR(s) ((s) ? (s) : "")
Otherwise this patch is probably ok. If nobody else has comments on it
I can commit it soon. I'll look at the others again too but in general
I didn't see anything objectionable.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
