Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 3 Feb 2013 18:24:20 -0800
From: Isaac Dunham <>
Subject: Re: [PATCH 3/4] String: expand to word-at-a-time

On Mon,  4 Feb 2013 00:12:14 +0000
Nathan McSween <> wrote:

> -int strcmp(const char *l, const char *r)
> +/**
> + * strcmp - Word sized c standard strcmp.
> + * @c: Comparative
> + * @s: Source
> + */
I have a few comments:

1: Why "comparative" and "source" instead of left/right?
Source implies that there's copying going on, which there isn't (at least in terms of the API).
s1/s2 or l/r is much more understandable.

2: For that many lines, you might as well explain what's going on:
/* Indicate whether string c is less than, greater than, or
equal to string s */
The comments are useless without the standard, and superfluous 
with it.

> +#undef strcmp
I don't see why this is needed, unless you messed up your build environment.

> +int strcmp(const char *c, const char *s)

What's the effect of all this on size of the binary?
I see that all this ends up adding ~150 lines.

Is shortening the length of the variable names really useful?

Isaac Dunham <>

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.