Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 2 Feb 2013 23:11:11 +0100
From: Szabolcs Nagy <>
Subject: Re: [PATCH] Add support for mkostemp, mkstemps and mkostemps

* John Spencer <> [2013-02-02 20:51:12 +0100]:
> +	unsigned long r = ts.tv_nsec + (uintptr_t)&ts / 16 + (uintptr_t)x6;

i recommend a multiplier here, eg. with

r = nsec*1664525 + A;

if only the last few bits of nsec are uniform random then
the top bits of A are not immediately known from r

..only the top bits of A*4276115653 can be known
(1664525*4276115653 == 1 mod 2^32)

and that's probably less useful for an attacker

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.