[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20121116092936.GI12537@port70.net>
Date: Fri, 16 Nov 2012 10:29:36 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: src/stdio/__stdio_read.c
* Yuri Kozlov <yuray@...yakino.ru> [2012-11-16 11:40:57 +0400]:
> size_t __stdio_read(FILE *f, unsigned char *buf, size_t len)
> {
> ssize_t cnt;
> ...
> cnt = syscall(SYS_readv, ...)
>
> if (cnt <= 0) {
> f->flags |= F_EOF ^ ((F_ERR^F_EOF) & cnt);
> f->rpos = f->rend = 0;
> return cnt;
> }
> ...
> }
>
> It not raise a problem when a signed value return as unsigned?
>
no, cnt is either 0 or -1 there (assuming readv works)
this is how __stdio_read is used (f->read):
for (; l; l-=k, dest+=k) {
k = __toread(f) ? 0 : f->read(f, dest, l);
if (k+1<=1) {
FUNLOCK(f);
return (len-l)/size;
}
}
it handles the k == -1 and k == 0 case
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
