Date: Sat, 20 Oct 2012 20:53:44 -0400 From: Rich Felker <dalias@...ifal.cx> To: musl@...ts.openwall.com Subject: Re: [PATCH 3/4] Import BSD functions defined in <netinet/ether.h> from NetBSD On Sun, Oct 21, 2012 at 02:57:44AM +0200, John Spencer wrote: > >This was for record of the original code from NetBSD, before > >patching it in [4/4] > > ah... so you sent patches that undo your earlier patches. > this doesnt make reviewing them simpler... > why didn't you simply merge them before sending ? I agree, reviewing would have been easier with them merged, but I can understand the interest in documenting the original source of the code. > >>anyway, i doubt it makes sense to add this crap; i never needed > >>it for sabotage which is almost feature complete and compiles > >>250 packages. > > > >I can not argue with this kind of comments. > > with crap, i was refering to these functions, not your work. > the point that i haven't needed these functions besides having > wpa_supplicant, wireless-tools, iptables and nmap in the repos still > stands. Note that gnulib has replacements for these functions, so if there are packages using gnulib which use them, they might just be pulling in the gnulib versions. Just a guess. Again, I would like to know some real-world examples of applications using them. Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.