Date: Thu, 16 Aug 2012 19:03:21 -0400 (EDT) From: idunham@...abit.com To: musl@...ts.openwall.com Subject: Re: [PATCH 1/3] makefile: add silent rules > make V=0 to enable them > --- Remind me what the _benefit_ is? I remember there were several advantages to standard full output, so the verdict was that *if* they're added, they get disabled by default. While this patch does respect that, I'd like to know whether there's a better reason for the added ugliness than "Some folks don't like to see what's happening"... Also, I note that you're also making a couple other changes: RM, LN, and INSTALL... Last time, Rich said he didn't see a reason to use $(RM), since rm is POSIX. Same can be said of ln/$(LN). install appears (per man 1p) to not be POSIX, but is fairly widespread. I can see this helping with the occasional broken version of install. Patch 3/3 is the most valuable part of the series, I think. I can see merging that, and patch 2/3 is trivial. > +LN = ln -sf > ALL_INCLUDES = $(sort $(wildcard include/*.h include/*/*.h) $(GENH)) > +V ?= 1 > + > +ifeq ($(strip $(V)), 0) > +Q = @ > +ECHO = printf "$(1)\t%s\n" $(2) > +BRIEF = CC AS AR LD HOSTCC SH LN > +SILENT = DEPCC RM RANLIB > +MSG = $@ > +M = @$(call ECHO,$(TAG),$@); > +$(foreach VAR,$(BRIEF), \ > + $(eval override $(VAR) = @$$(call ECHO,$(VAR),$$(MSG)); $($(VAR)))) > +$(foreach VAR,$(SILENT),$(eval override $(VAR) = @$($(VAR)))) > +$(eval INSTALL = @$(call ECHO,INSTALL,$$(^:$(SRC_PATH)/%=%)); $(INSTALL)) > +endif > -include config.mak Umm.... Is this an accident? > clean: > - rm -f crt/*.o > - rm -f $(OBJS) > - rm -f $(LOBJS) > - rm -f $(ALL_LIBS) lib/*.[ao] lib/*.so > - rm -f $(ALL_TOOLS) > - rm -f $(GENH) > - rm -f include/bits > + $(RM) crt/*.o > + $(RM) $(OBJS) > + $(RM) $(LOBJS) > + $(RM) $(ALL_LIBS) lib/*.[ao] lib/*.so > + $(RM) $(ALL_TOOLS) > + $(RM) $(GENH) > + $(RM) include/bits Axe this part (see above) > distclean: clean > - rm -f config.mak > + $(RM) config.mak > - ln -sf $(libdir)/libc.so $@ || true > + $(LN) $(libdir)/libc.so $@ || true See above. > $(DESTDIR)$(syslibdir): > - install -d -m 755 $(DESTDIR)$(syslibdir) > + $(INSTALL) -d -m 755 $(DESTDIR)$(syslibdir)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.