Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 19 Jun 2012 13:09:48 +0200
From: Jim Meyering <jim@...ering.net>
To: Bruno Haible <bruno@...sp.org>
Cc: bug-gnulib@....org,  musl@...ts.openwall.com,  Eric Blake <eblake@...hat.com>,  Rich Felker <dalias@...ifal.cx>,  Isaac Dunham <idunham@...abit.com>
Subject: Re: musl, fdopen test

Bruno Haible wrote:
...
>> My thought in having musl skip the test is to maximize performance of
>> fdopen, assuming you might be using it in a situation like on a newly
>> accept()ed network connection where every syscall counts (think
>> multi-threaded httpd). For read-only fdopen, no syscalls are needed,
>
> Sounds reasonable.
>
> Here's a proposed patch to remove gnulib's unintentional requirement.
>
>
> 2012-06-19  Bruno Haible  <bruno@...sp.org>
>
> 	fdopen: Allow implementations that don't reject invalid fd arguments.
> 	* m4/fdopen.m4 (gl_FUNC_FDOPEN): Let the test pass if fdopen(-1,...)
> 	succeeds.
> 	Reported by Rich Felker <dalias@...ifal.cx>.

Thanks, Bruno.
That patch looks perfect.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.