Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 10 Apr 2012 02:09:23 +0200
From: Pascal Cuoq <>
Subject: Re: float scanner status, upcoming release

On Mon, Apr 9, 2012 at 9:21 PM, Rich Felker <> wrote:
> And here's the current code (standalone test program) if anybody wants
> to play with it or point out how much single-letter variable names
> suck or whatnot.. :-)

Line 72:

			x[k] = x[k]*10 + c-'0';

I don't understand why this read access to x[k] is initialized.
If I change the declaration of local array x[] as:

  uint32_t x[KMAX] = { 1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1};


$ ./a.out
y = 11.123

Initializing x[] with arbitrary values shouldn't change anything
if it was not used uninitialized, right?

Even if I am getting something wrong here, you can count on me
to test the heck out of your function. I initially subscribed to
the musl mailing because I had been looking for a function like
this (although I let the musl source code distract me then).


Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.