Date: Fri, 6 Apr 2012 09:14:48 -0400 From: Rich Felker <dalias@...ifal.cx> To: musl@...ts.openwall.com Subject: Re: [PATCH] _BSD_SOURCE in math.h; MAXFLOAT is XOPEN only On Thu, Apr 05, 2012 at 10:32:27PM -0700, Isaac Dunham wrote: > This is pretty minor for the most part. > There was one issue I noticed: > _GNU_SOURCE defines MAXFLOAT here, but glibc only defines it if I'll add HUGE for _GNU_SOURCE, but I don't see any reason to duplicate the other ugly logic which was probably just a mistake anyway. To clarify the general policy: In musl, _GNU_SOURCE or _BSD_SOURCE should not break or remove functionality specified by the actual standards. They should just add the missing nonstandard stuff associated with GNU or BSD. Further, so far _GNU_SOURCE has been a superset of _XOPEN_SOURCE (i.e. anything under defined(_XOPEN_SOURCE) has ||defined(_GNU_SOURCE) with it). If it turns out this is a bad idea, I'm not entirely opposed to changing that, but just matching the exact set of definitions provided by glibc for its own sake is not a good enough reason to change. The goal is always compatibility with applications, not matching glibc. Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.