Date: Thu, 5 Apr 2012 22:51:15 -0400 From: Rich Felker <dalias@...ifal.cx> To: musl@...ts.openwall.com Subject: Re: [PATCH] _BSD_SOURCE for unistd.h, take 2 On Thu, Apr 05, 2012 at 07:40:45PM -0700, Isaac Dunham wrote: > On Thu, 5 Apr 2012 22:04:35 -0400 > Rich Felker <dalias@...ifal.cx> wrote: > > > > If I wanted to make things a little easier on those porting, I might > > > add something like this when _BSD_SOURCE is defined: > > > #warn "BSD setpgrp should be changed to setpgid" > > > That's not essential, though. > > The mismatching prototype should be enough to get a nice error. :) > > Sometimes I enjoy having a hint about how to change it, rather than > needing to read the glibc headers... > I put #warn instead of #error because they could well be using only the > other _BSD_SOURCE functions. I just mean the fact that the legacy BSD function's signature does not match the POSIX prototype will cause an error if the code is assuming the BSD version and trying to call it with the wrong number of arguments. > > Anyway, patch looks good now. Should I start committing or do you want > > to prepare a unified patch for all the headers? > > Feel free to start committing. > I may not be able to get all of the headers very soon, with my classes. > But this patch alone should solve at least one of Rob Landley's issues > with toybox (namely, chroot()). OK. Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.